admin_shortcuts_tags.py - fix for url_extra option - #43
Open
friedgit wants to merge 1 commit into
Open
Conversation
1. 'url_extra' could only ever take effect if the 'url_name' tag was specified rather than the 'url' tag, due I believe to incorrect indentation in the line in 'admin_shortcuts_tags.py' where the 'url_extra' tag is appended to the 'url'. 2. 'url_extra' could only be specified as a string to be appended, whereas one might expect to be able to specify a function, as in 'count' or 'count_new', which permit either a string or a function. This change fixes both issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'url_extra' could only ever take effect if the 'url_name' tag was specified rather than the 'url' tag, due I believe to incorrect indentation in the line in 'admin_shortcuts_tags.py' where the 'url_extra' tag is appended to the 'url'.
'url_extra' could only be specified as a string to be appended, whereas one might expect to be able to specify a function, as in 'count' or 'count_new', which permit either a string or a function.
This change fixes both issues